Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magiclysm: Fix assertion failure due to resizing child window #78652

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

abaire
Copy link
Contributor

@abaire abaire commented Dec 19, 2024

Summary

Bugfixes "Fixes imgui assertion triggered when reading scrolls in Magiclysm"

Purpose of change

Fixes #78476

Describe the solution

Just follows the instructions provided by the imgui assertion check.

Describe alternatives you've considered

Testing

Ran my saved game which exhibited the crash when reading a scroll, verified that I can now read the scroll and the child window is displayed.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) labels Dec 19, 2024
@github-actions github-actions bot requested a review from KorGgenT December 19, 2024 03:20
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 19, 2024
@paramendula
Copy link

please merge this

@Night-Pryanik Night-Pryanik merged commit bc462a8 into CleverRaven:master Dec 24, 2024
22 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIGABRT: Reading a scroll causes crash in spellbook_callback::refresh() -> ImGui:BeginChildEx
3 participants